Opened 7 years ago

Last modified 5 years ago

#1474 new bug

Test ~mpich2-1.3.2p1/src/mpi/romio/test/file_info.c incorrect test for default_striping_factor

Reported by: n4733@… Owned by:
Priority: major Milestone: future
Component: mpich Keywords:
Cc:

Description (last modified by balaji)

When the current ~mpich2-1.3.2p1/src/mpi/romio/test/file_info.c is run and the inquiry for the default_striping_factor returns a value of 2, an error message will always be printed about a striping_factor having an incorrect value. Just plug '2' into the equations to see that this is the case. The mod proposed below corrects this problem and is probably the code that was intended to be run. A couple of comments are also repaired or enhanced as well.

wilber~/MPICH2/functional/runrt/romio_io> diff file_info.1.3.2p1.mod.c file_info.1.3.2p1.orig.c
28c28
<  * error, default will be to increment error count for true error conditions
---
>  * error, default will be to increment errror cound for true error conditions
202c202
<    on Lustre, Intel PFS and IBM PIOFS file systems and are ignored elsewhere. 
---
>    on Intel PFS and IBM PIOFS file systems and are ignored elsewhere. 
253,256c253,255
<           if (default_striping_factor - 1 > 0) {
<                       if (atoi(value) != default_striping_factor-1) {
<                   errs++;
<                   if (verbose) fprintf(stderr, "striping_factor is %d; should be %d\n",
---
>           if ((default_striping_factor - 1 > 0) && (atoi(value) != default_striping_factor-1)) {
>               errs++;
>               if (verbose) fprintf(stderr, "striping_factor is %d; should be %d\n",
258d256
<               }
260,263c258,260
<             else {
<               if (atoi(value) != default_striping_factor) {
<                   errs++;
<                   if (verbose) fprintf(stderr, "striping_factor IS %d; should be %d\n",
---
>           else if (atoi(value) != default_striping_factor) {
>               errs++;
>               if (verbose) fprintf(stderr, "striping_factor is %d; should be %d\n",
265d261
<               }

Attachments (1)

file_info.c (11.9 KB) - added by n4733@… 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by n4733@…

comment:1 Changed 6 years ago by balaji

  • Milestone set to mpich2-1.5
  • Owner set to robl
  • Status changed from new to assigned

comment:2 Changed 6 years ago by balaji

  • Description modified (diff)

comment:3 Changed 5 years ago by balaji

  • Milestone changed from mpich2-1.5 to future

comment:4 Changed 5 years ago by balaji

  • Description modified (diff)
  • Owner robl deleted
  • Status changed from assigned to new
Note: See TracTickets for help on using tickets.