Opened 5 years ago

Closed 5 years ago

#1854 closed bug (invalid)

Match structure layout of 'MPID_Datatype' with 'MPIU_Handle_common'.

Reported by: blocksom Owned by: balaji
Priority: major Milestone: future
Component: mpich Keywords: ibm-integ
Cc: archerc@…

Description

This is a "difference" commit between mpich/master and mpich-ibm/build.

Change History (7)

comment:1 Changed 5 years ago by blocksom

I pushed this commit to mpich-ibm/ticket-1854.

comment:2 Changed 5 years ago by balaji

  • Milestone set to mpich-3.1
  • Owner set to balaji

comment:3 Changed 5 years ago by balaji

What's this patch doing? Why do you want to make a part of MPID_Datatype similar to MPIU_Handle_common?

comment:4 Changed 5 years ago by blocksom

  • Cc archerc@… added

Charles - do you remember why this was needed? This code change is a "left over" difference between the mpich/master and mpich-ibm/build branches. Originally, this came from a ginormous "pe code merge" squashed commit.

From a6991159f21cbb95aca36103a1de5396b0af6336 Mon Sep 17 00:00:00 2001
From: Joe Ratterman <jratt@us.ibm.com>
Date: Wed, 28 Sep 2011 16:05:45 -0500
Subject: [PATCH] Match structure layout of 'MPID_Datatype' with 'MPIU_Handle_common'.

(ibm) 17b9e8973047abdb461f0303bc6c15509aef160b
---
 src/mpid/common/datatype/mpid_datatype.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/mpid/common/datatype/mpid_datatype.h b/src/mpid/common/datatype/mpid_datatype.h
index 22041b2..06523e5 100644
--- a/src/mpid/common/datatype/mpid_datatype.h
+++ b/src/mpid/common/datatype/mpid_datatype.h
@@ -357,6 +357,8 @@ typedef struct MPID_Datatype {
     /* handle and ref_count are filled in by MPIU_Handle_obj_alloc() */
     MPIU_OBJECT_HEADER; /* adds handle and ref_count fields */
 
+    void *next;         /* adds this to match MPIU_Handle_common */
+
     /* basic parameters for datatype, accessible via MPI calls */
     int      size;
     MPI_Aint extent, ub, lb, true_ub, true_lb;
-- 
1.7.1

comment:5 Changed 5 years ago by balaji

  • Milestone changed from mpich-3.1 to future

Pushing this to "future". If IBM can get back to us on why this is needed, we can revisit it.

comment:6 Changed 5 years ago by blocksom

We reverted this change and are unable to recreate the problem. I pushed the revert to the mpich-ibm/build branch so that the file in question is identical to the mpich/master branch.

I think we can close this ticket and, if this ever shows up again, we can re-open it.

comment:7 Changed 5 years ago by balaji

  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.