Opened 9 years ago

Last modified 23 months ago

#90 new bug

issues around MPID_Dev_comm_create_hook(), etc.

Reported by: "Rajeev Thakur" <thakur@…> Owned by:
Priority: minor Milestone: future
Component: mpich Keywords:
Cc:

Description (last modified by balaji)

Need to look into this.

_

From: owner-mpich2-dev@… owner-mpich2-dev@… On
Behalf Of David Gingold
Sent: Thursday, August 07, 2008 8:48 PM
To: mpich2-dev@…
Subject: [mpich2-dev] issues around MPID_Dev_comm_create_hook(), etc.

I'm scrambling to get a release out, but lest I forget about this later, I
thought I should mention a few brief bits about MPID_Dev_comm_create_hook()
and friends:

  1. The callers of these don't check the return values. It would be nicer to

allow the hooks to pass errors up, e.g. if the create hook does memory
allocation.

  1. MPIR_Setup_intercomm_localcomm() doesn't call

MPID_Dev_comm_create_hook(). Should it? (This had me on a bit of a goose
chase this evening, but I'm better now.)

  1. I've ended up hanging device-specific things off the communicator that

might instead be hung off the communicator's group. (The bits, in my case,
are representations of what ranks are local versus off-node.) Should we have
MPID_Dev_group_{create,destroy}_hook() functions, also? I note that there is
already a MPID_DEV_GROUP_DECL facility.

-dg

--
David Gingold
Principal Software Engineer
SiCortex?
Three Clock Tower Place, Suite 210
Maynard MA 01754
(978) 897-0214 x224

Attachments (1)

part0001.html (2.9 KB) - added by Rajeev Thakur 9 years ago.
Added by email2trac

Download all attachments as: .zip

Change History (14)

Changed 9 years ago by Rajeev Thakur

Added by email2trac

comment:1 Changed 9 years ago by Rajeev Thakur

  • id set to 90

This message has 1 attachment(s)

comment:2 Changed 9 years ago by balaji

  • Milestone set to mpich2-1.1b1
  • Owner set to goodell

comment:3 Changed 9 years ago by balaji

  • Milestone changed from mpich2-1.1b1 to mpich2-1.1
  • Priority changed from major to minor

comment:4 Changed 9 years ago by balaji

  • Summary changed from FW: [mpich2-dev] issues around MPID_Dev_comm_create_hook(), etc. to issues around MPID_Dev_comm_create_hook(), etc.

comment:5 Changed 9 years ago by balaji

  • Milestone changed from mpich2-1.1 to mpich2-1.1.1

comment:6 Changed 8 years ago by goodell

  • Milestone changed from mpich2-1.1.1 to mpich2-1.1.2

comment:7 Changed 8 years ago by balaji

  • Milestone changed from mpich2-1.1.2 to mpich2-1.2

Milestone mpich2-1.1.2 deleted

comment:8 Changed 8 years ago by goodell

  • Description modified (diff)
  • Milestone changed from mpich2-1.2 to mpich2-1.2.1
  • Status changed from new to accepted

comment:9 Changed 8 years ago by goodell

  • Description modified (diff)
  • Milestone changed from mpich2-1.2.1 to mpich2-1.3

comment:10 Changed 7 years ago by thakur

  • Milestone changed from mpich2-1.3 to future

comment:11 Changed 5 years ago by balaji

  • Description modified (diff)
  • Status changed from accepted to new

comment:12 Changed 5 years ago by balaji

  • Owner goodell deleted

comment:13 Changed 23 months ago by jhammond

I'm not sure this ticket should remain open.

Regarding 1, callers in src/mpi/comm/commutil.c and src/mpid/ch3/src/ch3u_port.c are now checking the return values with MPIR_ERR_POP.

Regarding 2, MPIR_Setup_intercomm_localcomm calls MPIR_Comm_commit, which in turn calls MPID_Dev_comm_create_hook.

Note: See TracTickets for help on using tickets.